Skip to content

Fix doc link permission name#14972

Merged
kaxil merged 4 commits into
apache:masterfrom
astronomer:fix-doc-link-permission-name
Mar 31, 2021
Merged

Fix doc link permission name#14972
kaxil merged 4 commits into
apache:masterfrom
astronomer:fix-doc-link-permission-name

Conversation

@jhtimmins

@jhtimmins jhtimmins commented Mar 24, 2021

Copy link
Copy Markdown
Contributor

Converts the docs_link permission resource name to Documentation.

This is an extension of #14946, which standardized default FAB permissions.

@boring-cyborg boring-cyborg Bot added the area:webserver Webserver related Issues label Mar 24, 2021
@github-actions

Copy link
Copy Markdown
Contributor

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@kaxil

kaxil commented Mar 24, 2021

Copy link
Copy Markdown
Member

Please rebase on latest Master, failing doc build should be fixed by #14986

@jhtimmins jhtimmins force-pushed the fix-doc-link-permission-name branch from fe2adcb to 8958f41 Compare March 24, 2021 22:10
@kaxil kaxil force-pushed the fix-doc-link-permission-name branch from 8958f41 to 50cc4d2 Compare March 25, 2021 14:24
@github-actions

Copy link
Copy Markdown
Contributor

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions Bot added the full tests needed We need to run full set of tests for this PR to merge label Mar 26, 2021
@kaxil kaxil merged commit 1bec3b2 into apache:master Mar 31, 2021
@kaxil kaxil deleted the fix-doc-link-permission-name branch March 31, 2021 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:webserver Webserver related Issues full tests needed We need to run full set of tests for this PR to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants