Skip to content

Create a documentation package for Docker image#14846

Merged
potiuk merged 4 commits into
apache:masterfrom
mik-laj:optimiize-new-docs
Mar 21, 2021
Merged

Create a documentation package for Docker image#14846
potiuk merged 4 commits into
apache:masterfrom
mik-laj:optimiize-new-docs

Conversation

@mik-laj

@mik-laj mik-laj commented Mar 17, 2021

Copy link
Copy Markdown
Member

New packages are prioritized because they have no inventory, which causes all other builds to fail.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@github-actions

Copy link
Copy Markdown
Contributor

The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the workflow link to check the reason.

@github-actions github-actions Bot added the okay to merge It's ok to merge this PR as it does not require more tests label Mar 17, 2021
@github-actions

Copy link
Copy Markdown
Contributor

The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest master or amend the last commit of the PR, and push it with --force-with-lease.

@kaxil kaxil added the full tests needed We need to run full set of tests for this PR to merge label Mar 17, 2021
@mik-laj mik-laj force-pushed the optimiize-new-docs branch from 05231d4 to 689cbd6 Compare March 17, 2021 20:06
@github-actions

Copy link
Copy Markdown
Contributor

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@mik-laj mik-laj force-pushed the optimiize-new-docs branch from 689cbd6 to 67cc291 Compare March 18, 2021 08:06
@mik-laj mik-laj changed the title Optimize docs build for new packages Create a documentation package for Docker image Mar 18, 2021
@mik-laj mik-laj requested review from kaxil and potiuk March 18, 2021 10:55
@mik-laj

mik-laj commented Mar 18, 2021

Copy link
Copy Markdown
Member Author

New documentation package for Docker Image has been reverted #14867. So I am adding it again in this change.

CC: @kaxil @potiuk

@ashb ashb added this to the Airflow 2.0.2 milestone Mar 18, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a redirect for this page to the new location?

@mik-laj mik-laj Mar 18, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This page still exists, so we can't redirect the user. Instead of old content with multiple sections, we now have one section with a link to the new package.

Screenshot 2021-03-18 at 13 17 05

@mik-laj mik-laj force-pushed the optimiize-new-docs branch 2 times, most recently from 4940ffe to 7891520 Compare March 19, 2021 14:48
@mik-laj mik-laj force-pushed the optimiize-new-docs branch from 7891520 to 010cbc3 Compare March 20, 2021 16:42
@mik-laj

mik-laj commented Mar 21, 2021

Copy link
Copy Markdown
Member Author

@kaxil Ci are green. Can you look at it?

potiuk pushed a commit that referenced this pull request Mar 23, 2021
potiuk pushed a commit that referenced this pull request Mar 25, 2021
ashb pushed a commit that referenced this pull request Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

full tests needed We need to run full set of tests for this PR to merge kind:documentation okay to merge It's ok to merge this PR as it does not require more tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants