Use plain asserts in tests.

[jmcarp]

We have talked about switching from unittest-style assertions (like self.assertEqual(foo, bar)) to plain pytest-style assertions (like assert foo == bar) on slack and the mailing list, but it doesn't seem like we've decided so far. I wanted to send a sample PR to show how this might work. I generated these changes with a one-line command:

unittest2pytest -f self_assert tests/core -w

If we try to refactor many tests at once, we'll likely run into conflicts, but because we can auto-refactor the code easily, fixing conflicts should be straightforward too.

Note that I didn't use the remove_class fixer or move test setup into fixtures--this just concerns assertion style.

Does this seem like an improvement? If so, we can refactor tests module by module, or run unittest2pytest on all the tests at once.

cc @ashb @potiuk

[github-actions]

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

[github-actions]

The Workflow run is cancelling this PR. Building image for the PR has been cancelled

[turbaszek]

Thanks @jmcarp for the PR!

doesn't seem like we've decided so far

We've reached consensus that we prefer assert x == y but it was postponed until we release and stabilise Airflow 2.0.

[github-actions]

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

[github-actions]

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

[potiuk]

The failed test is https://github.com/apache/airflow/pull/12951/checks?check_run_id=1675678142#step:6:890 - looking at it, I think it either should be moved to quarantine or fixed.

[jmcarp]

I'm marking that test as quarantined. It passes locally, and behavior seems inconsistent from CI.

[github-actions]

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

[github-actions]

The Workflow run is cancelling this PR. Building image for the PR has been cancelled

[jmcarp]

Rebased. The last failing tests I saw seemed random and unrelated to these changes.

[turbaszek]

There's an error which seems to be present in multiple builds, so I think we should take a look at that:

  tests/core/test_configuration.py:518: 
915
  _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
916
  
917
  self = <tests.test_utils.reset_warning_registry.reset_warning_registry object at 0x7f0b78239f50>
918
  
919
      def __enter__(self):
920
          # archive and clear the __warningregistry__ key for all modules
921
          # that match the 'reset' pattern.
922
          pattern = self._pattern
923
          backup = self._backup = {}
924
          for name, mod in list(sys.modules.items()):
925
              if pattern.match(name):
926
                  reg = getattr(mod, "__warningregistry__", None)
927
                  if reg:
928
  >                   backup[name] = reg.copy()
929
  E                   AttributeError: 'str' object has no attribute 'copy'

[github-actions]

The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.

[potiuk]

Hey @jmcarp -> I had to cancel this run because of this random GitHub error https://github.com/apache/airflow/runs/1699834461?check_suite_focus=true#step:10:310

Can you please --amend/push again?

BTW. We have a meeting today with INFRA and GitHub developer advocate https://cwiki.apache.org/confluence/display/INFRA/ASF+Builds+Agenda+2021-01-14, as this is releted to erratic behaviour of Github Registry

[github-actions]

The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.

[github-actions]

The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.

[github-actions]

The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.

[github-actions]

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

[jmcarp]

Ok, I think tests are in good shape and the failures are random (quarantined tests) or a formatting regression in setup.cfg that's already in the master branch.

[potiuk]

Yeah. There Was an extra space (!) added in setup.cfg but it has been fixed since :)

[potiuk]

Thanks for your patience @jmcarp! :) The CI problems did not make it easier.