Add DBApiHook check for 2.0 migration#12730
Merged
Merged
Conversation
potiuk
approved these changes
Dec 1, 2020
Contributor
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
Bot
added
the
full tests needed
Adds a check that ensures that any hook that uses the run, get_pandas_df or get_records functions does not import from the base_hook
dimberman
force-pushed
the
check-sql-hook
branch
from
December 7, 2020 04:50
2b05541 to
74ea7ce
Compare
turbaszek
reviewed
Dec 8, 2020
| get_records = check_get_records(child) | ||
| if get_records: | ||
| incorrect_implementations.append(get_records) | ||
| return incorrect_implementations |
Member
There was a problem hiding this comment.
This rule only verifies custom hooks but not operators that may use BaseHook methods. Btw. will it work with hooks defined on PYTHONPATH or in plugins?
Contributor
Author
There was a problem hiding this comment.
@turbaszek are there operators that inherit from BaseHook? What would an example operator be?
I think it should work with anything i the globals
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a check that ensures that any hook that uses the
run, get_pandas_df or get_records functions does not import from the
base_hook
addresses #11039
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.