Skip to content

Fix static checks - #12715#12729

Merged
kaxil merged 1 commit into
apache:masterfrom
PolideaInternal:pr-static-echecks
Dec 1, 2020
Merged

Fix static checks - #12715#12729
kaxil merged 1 commit into
apache:masterfrom
PolideaInternal:pr-static-echecks

Conversation

@mik-laj

@mik-laj mik-laj commented Dec 1, 2020

Copy link
Copy Markdown
Member

Related: #12715


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@github-actions

github-actions Bot commented Dec 1, 2020

Copy link
Copy Markdown
Contributor

The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.

@mik-laj mik-laj requested review from kaxil and potiuk December 1, 2020 07:35

@potiuk potiuk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some errors though

@github-actions

github-actions Bot commented Dec 1, 2020

Copy link
Copy Markdown
Contributor

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions Bot added the full tests needed We need to run full set of tests for this PR to merge label Dec 1, 2020
@kaxil

kaxil commented Dec 1, 2020

Copy link
Copy Markdown
Member

Looks like it is stuck -- I am going to merge anyway to unblock master failure

@kaxil kaxil merged commit 027fd74 into apache:master Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools full tests needed We need to run full set of tests for this PR to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants