Missing review history when tasks are cleared (HITL)

[cmarteepants]

Description

We are not showing the history of review actions after tasks are cleared. As you can see in the audit log, I ran a dag using the approval operator, approved it, then cleared the approval task and all downstream dependencies, then rejected it.

However, when I look at the table within the dag view, I only see one entry.

Same thing when I look across all dags (under Browse)

We are missing the history from retries. This is from the main branch.

(Note: There is going to be a bit of UX cleanup from Brent, and one of the things is that we are going to rename places that show outstanding actions to "Needs Review" and places that show open and resolved tasks to "Review History".)

Code of Conduct

• I agree to follow this project's Code of Conduct

[Lee-W]

This is an intentional design. May I know why we want it to be there?

[cmarteepants]

Thanks for clarifying this was intentional. Could you share a bit more about the reasoning? I want to make sure I'm not missing the context.

From my side, having the full history is important for:

• Debugging: aka a data quality check fails, someone approves are publishing, later clears/rejects. If I only see "rejected", I lose the key context that it was once approved

• Completeness / Consistency: We already show logs and metadata for cleared tasks, so it feels natural to include the same for approvals.

I know Brent has open UX discussions on splitting "review history" vs "reviews that need action" (link), but that seems to depend on the backend capturing the full chain first.

[Lee-W]

Thanks for clarifying this was intentional. Could you share a bit more about the reasoning? I want to make sure I'm not missing the context.

From my side, having the full history is important for:

* Debugging: aka a data quality check fails, someone approves are publishing, later clears/rejects. If I only see "rejected", I lose the key context that it was once approved

* Completeness / Consistency: We already show logs and metadata for cleared tasks, so it feels natural to include the same for approvals.

I know Brent has open UX discussions on splitting "review history" vs "reviews that need action" (link), but that seems to depend on the backend capturing the full chain first.

The implementation introduced unnecessary complexity without providing any benefits beyond an audit log, which is why I chose not to add it.

However, the consistency apart does seem valid. I will review it to see how it can be effectively added. Thanks for clarifying!