Potential issue with use of serialize in Looker SDK

[friedmanmax]

Apache Airflow Provider(s)

google

Versions of Apache Airflow Providers

apache-airflow-providers-common-sql==1.3.4
apache-airflow-providers-ftp==3.3.1
apache-airflow-providers-google==8.11.0
apache-airflow-providers-http==4.2.0
apache-airflow-providers-imap==3.1.1
apache-airflow-providers-sqlite==3.3.1

Apache Airflow version

2

Operating System

OS X (same issue on AWS)

Deployment

Amazon (AWS) MWAA

Deployment details

No response

What happened

I wrote a mod on top of LookerHook to access the scheduled_plan_run_once endpoint. The result was the following error.

  File "/usr/local/airflow/dags/utils/looker_operators_mod.py", line 125, in execute
    resp = self.hook.run_scheduled_plan_once(
  File "/usr/local/airflow/dags/utils/looker_hook_mod.py", line 136, in run_scheduled_plan_once
    resp = sdk.scheduled_plan_run_once(plan_to_send)
  File "/usr/local/lib/python3.9/site-packages/looker_sdk/sdk/api40/methods.py", line 10273, in scheduled_plan_run_once
    self.post(
  File "/usr/local/lib/python3.9/site-packages/looker_sdk/rtl/api_methods.py", line 171, in post
    serialized = self._get_serialized(body)
  File "/usr/local/lib/python3.9/site-packages/looker_sdk/rtl/api_methods.py", line 156, in _get_serialized
    serialized = self.serialize(api_model=body)  # type: ignore
TypeError: serialize() missing 1 required keyword-only argument: 'converter'

I was able to get past the error by rewriting the get_looker_sdk function in LookerHook to initialize with looker_sdk.init40 instead, which resolved the serialize() issue.

What you think should happen instead

I don't know why the serialization piece is part of the SDK initialization - would love some further context!

How to reproduce

As far as I can tell, any call to sdk.scheduled_plan_run_once() causes this issue. I tried it with a variety of different dict plans. I only resolved it by changing how I initialized the SDK

Anything else

n/a

Are you willing to submit PR?

• Yes I am willing to submit a PR!

Code of Conduct

• I agree to follow this project's Code of Conduct

[boring-cyborg]

Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for approval.

[potiuk]

@alekseiloginov I think you have contributed it, so maybe you can take a look and see where it is now. Otherwise it will have to wait for someone who would like to pick it as good-first-issue.

[alekseiloginov]

@joeldodge79 Can you take a look? I think the issues related to this line of code:
https://github.com/looker-open-source/sdk-codegen/blob/f0a70b9d6cec8e09bc506c38ea02627fad2dd356/python/looker_sdk/rtl/api_methods.py#L156

[rollyjoel]

may be related to looker-open-source/sdk-codegen#288

@jeremytchang or @jkaster can you triage?

[eladkal]

@joeldodge79 I tend to close this issue as this is upstream library issue and once they resolve it the issue will be fixed.
can you confirm?

[github-actions]

This issue has been automatically marked as stale because it has been open for 30 days with no response from the author. It will be closed in next 7 days if no further activity occurs from the issue author.