The grid view shows incorrect DAG runs

[zachliu]

Apache Airflow version

2.4.0

What happened

Airflow 2.4.0's grid view has an issue:

Grid view stop showing the latest DAG runs in 2.4.0 (regardless of schedule, it shows old dag runs)

• case 1 (all 25 are old dag runs)
  

• case 2 (old and new dag runs are mixed)
  
  

What you think should happen instead

No response

How to reproduce

1. Go to a DAG with >365 dag runs
2. The place where it's supposed to show the latest dag run in the "grid view" now shows an old dag run ~1 year ago

Operating System

Linux Mint 20.3 Una

Versions of Apache Airflow Providers

No response

Deployment

Other Docker-based deployment

Deployment details

No response

Anything else

No response

Are you willing to submit PR?

• Yes I am willing to submit a PR!

Code of Conduct

• I agree to follow this project's Code of Conduct

[zachliu]

most likely due to #25633 and #25880
@uranusjr @bbovenzi any idea how to solve this? i'm not familiar with the "timetable" part 😅

[kxepal]

Hi there! Follow up from dev ML.

We faced exactly the same issue after upgrade from 2.3.4 to 2.4.0 for all our dags. All of them has quite a history up to 2016 year, so a lot of dag runs. Somehow grid show for us latest runs at 2021.11 while other views (calendar, graph) shows all of them and the most recent ones.

The exact fix which solved this problem is:

--- airflow/www/views.py
+++ airflow/www/views.py
@@ -3453,8 +3460,9 @@ class Airflow(AirflowBaseView):
             if run_state:
                 query = query.filter(DagRun.state == run_state)
 
-            ordering = (DagRun.__table__.columns[name].desc() for name in dag.timetable.run_ordering)
-            dag_runs = query.order_by(*ordering, DagRun.id.desc()).limit(num_runs).all()
+            dag_runs = query.order_by(DagRun.execution_date.desc()).limit(num_runs).all()
             dag_runs.reverse()
 
             encoded_runs = [wwwutils.encode_dag_run(dr) for dr in dag_runs]

It feels like there is a problem between data and logic that operates it, but not sure where and what is it.

[ashb]

@uranusjr Can you take a look at this ASAP please so we can get a fix for this out in 2.4.1?

[ashb]

@kxepal What is the timetable/schedule parameter for the DAG(s) with this problem?

[kxepal]

@ashb we have good old timedelta schedule interval value everywhere. No timetables at all.

[zachliu]

@kxepal doesn't the fix actually revert the core of #25633? i also did that because i "accidentally" deployed airflow 2.4.0 to our production 🤫

[kxepal]

@zachliu That PR contains a lot of changes, but for us was enough to revert those changes that in the diff. The rest of them causes no troubles.

[zachliu]

@kxepal taking a wild guess here, maybe a if can solve all: if timetables are used, do that; else, do this