You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There has been previous attempt to add this operator in #10011
But now after #23971 is completed this should be much easier as DbApiHook has unified run method that works for all providers (with some configuration of parameters like split_statements etc..)
We can now explore again the option of SqlExecuteQueryOperator
There are two approaches that I can think of:
Creating a BaseSqlExecuteQueryOperator that all Sql related operators (PostgresOperator, MySqlOperator, SnowflakeOperator) will inherit from.
Personally I prefer to try the 2nd approach first (It should be similar to what we do in SqlSensor or SqlBranchOperator the issue to resolve is how to handle the batch queries in some of the DBs and that is now should be possible thanks to #23971 in SqlSensor / SqlBranchOperator executing batch queries was never an issue as they are expected to execute only 1 SQL statement )
Body
There has been previous attempt to add this operator in #10011
But now after #23971 is completed this should be much easier as
DbApiHookhas unified run method that works for all providers (with some configuration of parameters likesplit_statementsetc..)We can now explore again the option of
SqlExecuteQueryOperatorThere are two approaches that I can think of:
BaseSqlExecuteQueryOperatorthat all Sql related operators (PostgresOperator,MySqlOperator,SnowflakeOperator) will inherit from.SqlExecuteQueryOperator(just like Add SQLExecuteQueryOperator operator #10011 attempted to do)Personally I prefer to try the 2nd approach first (It should be similar to what we do in
SqlSensororSqlBranchOperatorthe issue to resolve is how to handle the batch queries in some of the DBs and that is now should be possible thanks to #23971 inSqlSensor/SqlBranchOperatorexecuting batch queries was never an issue as they are expected to execute only 1 SQL statement )FYI @potiuk @kazanzhy
Committer