Fix centering of hourly interval#153
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #153 +/- ##
=======================================
Coverage 70.52% 70.52%
=======================================
Files 12 12
Lines 1133 1133
Branches 153 153
=======================================
Hits 799 799
Misses 317 317
Partials 17 17
Continue to review full report at Codecov.
|
mhidas
force-pushed
the
fix_hourly_interval
branch
from
d1628ff to
3980c1c
Compare
mhidas
force-pushed
the
fix_hourly_interval
branch
from
3980c1c to
96f8040
Compare
leonardolaiolo
approved these changes
May 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The averaging intervals for the hourly product were not actually centered on the hour (as specified) due to an issue with specifying units in
pandas.Timedelta(see #99 (comment))(Still need to check whether the same fix need to be applied to the velocity_hourly product - but if so this will be done in a separate PR)