Skip to content

Broker refactor - final tweak#227

Merged
3 commits merged into
broker-refactorfrom
broker-refactor_mhidas
Jan 18, 2021
Merged

Broker refactor - final tweak#227
3 commits merged into
broker-refactorfrom
broker-refactor_mhidas

Conversation

@mhidas
Copy link
Copy Markdown
Contributor

@mhidas mhidas commented Jan 18, 2021

I tried to update some of the moorings handlers in aodndata to work with this. It failed when I tried to add an existing URL (not local path) as a deletion, like this (code is here, but now updated):

                self.add_to_collection(old_product_url, dest_path=old_product_url,
                                       is_deletion=True, late_deletion=True,
                                       publish_type=PipelineFilePublishType.DELETE_UNHARVEST)

I specified it as is_deletion, because that's what the arg is called everywhere, except PipelineFileCollection.add(), which was calling it deletion. So let's make it consistent.

And while I'm at it, let's bump the version number?

@mhidas mhidas requested a review from a user January 18, 2021 06:33
@mhidas mhidas changed the title Broker refactor mhidas Broker refactor - final tweak Jan 18, 2021
@ghost ghost merged commit 042c478 into broker-refactor Jan 18, 2021
@ghost ghost deleted the broker-refactor_mhidas branch January 18, 2021 06:42
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant