Update documentation#224
Draft
ghost wants to merge 2 commits into
Draft
Conversation
ghost
Codecov Report
@@ Coverage Diff @@
## master #224 +/- ##
=======================================
Coverage 91.81% 91.81%
=======================================
Files 36 36
Lines 3664 3664
Branches 418 418
=======================================
Hits 3364 3364
Misses 249 249
Partials 51 51 Continue to review full report at Codecov.
|
mhidas
reviewed
Jan 19, 2021
| # create a PipelineFile to represent the product file, set it's 'publish type' | ||
| # attribute and add it to the handler's file collection | ||
| # add the path to the handler's file collection, with keyword arguments being used to construct the | ||
| # PipelineFile |
Contributor
There was a problem hiding this comment.
Maybe add a link to PipelineFile.__init__?
| product = PipelineFile(product_path) | ||
| product.publish_type = PipelineFilePublishType.UPLOAD_ONLY | ||
| self.collection.add(product) | ||
| self.add_to_collection(product) |
Contributor
There was a problem hiding this comment.
Add a note that in this case (where the first arg is a PipelineFile), additional kwargs passed to add_to_collection have no effect (as per note in the docstring)
mhidas
reviewed
Jan 27, 2021
| dest_filename = "IMOS_filename_01_XX_{basename}".format(basename=basename) | ||
| return os.path.join('IMOS/MYFACILITY', dest_filename) | ||
|
|
||
| * Writing :meth:`dest_path` and :meth:`archive_path` functions with an unmodified filename: |
Contributor
There was a problem hiding this comment.
Suggested change
| * Writing :meth:`dest_path` and :meth:`archive_path` functions with an unmodified filename: | |
| * Writing :meth:`dest_path` and :meth:`archive_path` functions with a modified filename: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.