WfsBroker methods to accept OgcExpression filters not XML#211
Closed
mhidas wants to merge 7 commits into
Closed
Conversation
…StateQuery. Move instantiation of WfsBroker out of StateQuery.
…ameters in subclasses
…ert them to XML when necessary
Contributor
Author
|
@lwgordonimos What do you think? Could we add something along these lines to your refactoring PR? |
Codecov Report
@@ Coverage Diff @@
## broker-refactor #211 +/- ##
==================================================
Coverage ? 90.75%
==================================================
Files ? 35
Lines ? 3482
Branches ? 424
==================================================
Hits ? 3160
Misses ? 262
Partials ? 60
Continue to review full report at Codecov.
|
|
Good ideas. I've added it to the "general client API improvements PR": #209 |
ghost
force-pushed
the
broker-refactor
branch
from
4eed8f4 to
e7b786f
Compare
ghost
force-pushed
the
broker-refactor
branch
from
e7b786f to
a13bf9d
Compare
ghost
force-pushed
the
broker-refactor
branch
from
a13bf9d to
2489daf
Compare
ghost
force-pushed
the
broker-refactor
branch
from
2489daf to
425af6a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When querying WFS, we construct filters using
owslib.fes.OgcExpressionobjects. We only need to convert them to XML when we send the getFeature request. So I think this should just be done "under the hood" automatically, rather than requiring the hanlder to do it (e.g. here).Also, I think the use of
ogc_filterto denote bothOgcExpressionobjects and XML was confusing.