fix: correct content_block_delta deserialization in streaming#1653
Open
Oxygen56 wants to merge 1 commit into
Open
fix: correct content_block_delta deserialization in streaming#1653Oxygen56 wants to merge 1 commit into
Oxygen56 wants to merge 1 commit into
Conversation
Fix handling of content_block_delta event variants during streaming to prevent dropped events. The root cause: when construct_type() is called with both an Annotated-wrapped type AND explicit metadata, get_origin() returns 'Annotated' rather than the inner union type, causing none of the type-check branches to match. The function then falls through to return value, yielding a raw dict instead of a proper model. Two-part fix: 1. construct_type(): Always unwrap Annotated from type_, even when metadata was explicitly passed by _construct_field. 2. _build_discriminated_union_meta(): Also unwrap Annotated from the union parameter, so get_args() yields individual variant types rather than (UnionType, metadata). Fixes anthropics#941 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes content_block_delta event deserialization during streaming.
Fixes #941