Re-enable ansible-sanity job#171
Open
pabelanger wants to merge 1 commit into
Open
Conversation
Contributor
|
Build failed.
|
Now that I better understand what is going on why this job was failing, re enable it. We've made changes to the job with how branches work in zuul. This also fixes up ansible-sanity errors to make the job pass. Signed-off-by: Paul Belanger <pabelanger@redhat.com>
Contributor
Author
|
Pull-request updated, HEAD is now 7d65c4e |
pabelanger
force-pushed
the
temp/enable-sanity
branch
from
7f9860c to
7d65c4e
Compare
Contributor
|
Build succeeded.
|
Contributor
Author
|
recheck |
Contributor
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
trishnaguha
requested changes
Oct 16, 2018
Member
There was a problem hiding this comment.
Please do not enable this or merge this change as this fix was released with Ansbile2.7.1 not 2.7.0.
So this will break user on Ansible 2.7.0. If we want to merge this, Ansible minimum version has to be 2.7.1 for this role.
This is why I haven't merged this PR #160
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that I better understand what is going on why this job was failing,
re enable it. We've made changes to the job with how branches work in
zuul.
Signed-off-by: Paul Belanger pabelanger@redhat.com