fix(acp): Fix memory leak in session event streams#9146
Closed
sauerdaniel wants to merge 1 commit intoanomalyco:devfrom
Closed
fix(acp): Fix memory leak in session event streams#9146sauerdaniel wants to merge 1 commit intoanomalyco:devfrom
sauerdaniel wants to merge 1 commit intoanomalyco:devfrom
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: No duplicate PRs found |
2 tasks
opencode-agent
Bot
force-pushed
the
dev
branch
from
00637c0 to
71e0ba2
Compare
thdxr
force-pushed
the
dev
branch
3 times, most recently
from
f1ae801 to
08fa7f7
Compare
sauerdaniel
force-pushed
the
pr/memory-acp
branch
from
a4a5836 to
fd46aee
Compare
Contributor
Author
|
Rebased onto latest dev and resolved merge conflicts.\n\nChanges adapted to the current architecture:\n- Added |
This was referenced Feb 11, 2026
sauerdaniel
force-pushed
the
pr/memory-acp
branch
7 times, most recently
from
8fa9ddc to
f126b34
Compare
sauerdaniel
force-pushed
the
pr/memory-acp
branch
from
f126b34 to
ec0c301
Compare
Add cleanup mechanism for ACP session map and event streams to prevent unbounded growth. Implements proper session lifecycle management.
sauerdaniel
force-pushed
the
pr/memory-acp
branch
from
ec0c301 to
2cd03ac
Compare
binarydoubling
added a commit
to binarydoubling/opencode
that referenced
this pull request
Mar 9, 2026
Addresses the remaining memory leaks identified in anomalyco#16697 by consolidating the best fixes from 23+ open community PRs into a single coherent changeset. Fixes consolidated from PRs: anomalyco#16695, anomalyco#16346, anomalyco#14650, anomalyco#15646, anomalyco#13186, anomalyco#10392, anomalyco#7914, anomalyco#9145, anomalyco#9146, anomalyco#7049, anomalyco#16616, anomalyco#16241 - Plugin subscriber stacking: unsub before re-subscribing in init() - Subagent deallocation: Session.remove() after task completion - SSE stream cleanup: centralized cleanup with done guard (3 endpoints) - Compaction data trimming: clear output/attachments on prune - Process exit cleanup: Instance.disposeAll() with 5s timeout - Serve cmd: graceful shutdown instead of blocking forever - Bash tool: ring buffer with 10MB cap instead of O(n²) concat - LSP index teardown: clear clients/broken/spawning on dispose - LSP open-files cap: evict oldest when >1000 tracked files - Format subscription: store and cleanup unsub handle - Permission/Question clearSession: reject pending on session delete - Session.remove() cleanup chain: FileTime, Permission, Question - ShareNext subscription cleanup: store unsub handles, cleanup on dispose - OAuth transport: close existing before replacing Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
6 tasks
Contributor
|
Closing this pull request because it has had no updates for more than 60 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix ACP session resource cleanup to prevent stale session state and leaked per-session resources.
Fixes #9154
Relates to #5363
Problem
ACP sessions were not fully cleaned up when sessions were deleted, leaving stale entries in session maps and per-session permission queues.
Solution
Changes
Testing
AI-Assisted
Yes