core: fix npm package detection to properly handle cached directories without installed packages#25354
Merged
Conversation
… without installed packages
Collaborator
Author
|
/review |
Contributor
|
lgtm |
66 tasks
oleksii-honchar
pushed a commit
to oleksii-honchar/better-opencode
that referenced
this pull request
May 6, 2026
… without installed packages (anomalyco#25354)
legion-implementer Bot
pushed a commit
to sjawhar/opencode
that referenced
this pull request
May 10, 2026
…ry specs For non-registry specs (remote tarball URLs, git+https://, github: shorthand, file: paths), npa(pkg).name returns undefined - only registry packages have inferable names from the spec alone. Read the install-root package.json written by Arborist on the initial install to recover the actual installed package name from its first dependency entry. When the cache directory exists but is empty (no package.json), fall through to the Arborist install path instead of returning a likely-failing entrypoint resolution. This preserves upstream's anomalyco#25354 fix for empty cache dirs while adding the cached-name resolution for non-registry specs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #24431