fix(httpapi): preserve OpenAPI parameter parity#25291
Merged
Merged
Conversation
kitlangton
commented
May 1, 2026
| const PathParameterSchemas = { | ||
| sessionID: { type: "string", pattern: "^ses.*" }, | ||
| messageID: { type: "string", pattern: "^msg.*" }, | ||
| partID: { type: "string", pattern: "^prt.*" }, |
Contributor
Author
There was a problem hiding this comment.
this code is awful.
kitlangton
commented
May 1, 2026
| const PathParameterSchemas = { | ||
| sessionID: { type: "string", pattern: "^ses.*" }, | ||
| messageID: { type: "string", pattern: "^msg.*" }, | ||
| partID: { type: "string", pattern: "^prt.*" }, |
kitlangton
commented
May 1, 2026
| const override = QueryParameterSchemas[`${route} ${param.name}` as keyof typeof QueryParameterSchemas] | ||
| if (override) { | ||
| param.schema = override | ||
| if (!param.schema || typeof param.schema !== "object") return |
Contributor
Author
There was a problem hiding this comment.
THIS CODE IS HOT GARBAGE. IN A GOOD WAY.
kitlangton
commented
May 1, 2026
| const override = QueryParameterSchemas[`${route} ${param.name}` as keyof typeof QueryParameterSchemas] | ||
| if (override) { | ||
| param.schema = override | ||
| if (!param.schema || typeof param.schema !== "object") return |
66 tasks
oleksii-honchar
pushed a commit
to oleksii-honchar/better-opencode
that referenced
this pull request
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Notes