Skip to content

fix: Show correct file paths in permission window#25

Merged
adamdotdevin merged 2 commits into
anomalyco:devfrom
mark3labs:fix-paths-in-permission-window
May 16, 2025
Merged

fix: Show correct file paths in permission window#25
adamdotdevin merged 2 commits into
anomalyco:devfrom
mark3labs:fix-paths-in-permission-window

Conversation

@ezynda3
Copy link
Copy Markdown
Contributor

@ezynda3 ezynda3 commented May 16, 2025

Summary

  • Fix filepath when asking for edit permissions

Test plan

  • Test creating/editing files and verify the permission window shows the correct file path

Fixes: #22

🤖 Generated with opencode

@adamdotdevin adamdotdevin merged commit c92f7c6 into anomalyco:dev May 16, 2025
randomm referenced this pull request in randomm/opencode Jan 9, 2026
…ns (#26)

BREAKING CHANGE: Replaces dual-container setup with unified container

Merges opencode_sandbox and opencode_with_ssh into single unified 
container accessible via both docker exec (Mac) and SSH (iPhone).

Major improvements:
- Single container with dual access (docker exec + SSH)
- Persistent screen sessions shared between devices
- Smart helper script (scripts/opencode) auto-attaches or creates
- GitHub CLI available from all access methods
- Docker socket access for MCP servers
- Dynamic Docker GID detection (cross-platform compatible)
- Robust screen session initialization (no race conditions)

Components added:
- Dockerfile.opencode-unified (merged features from both old Dockerfiles)
- docker-compose.yml (unified compose with Tailscale sidecar)
- entrypoint-unified.sh (SSH daemon + gh auth + screen session)
- scripts/opencode (smart launcher with attach logic)
- .screenrc (persistent session config)
- docs/session-management.md (usage guide)
- MIGRATION.md (upgrade guide)
- tests/test_unified_container.bats (test suite)

Review process:
- Initial review: 7 issues found (3 critical, 4 major)
- Fixes applied in f1a7b7d
- Re-review: All issues verified fixed, APPROVED

Closes #25
xywsxp pushed a commit to xywsxp/opencode that referenced this pull request Apr 24, 2026
* Fix paths in permission window to show relative paths

* Fix paths in permission window to show actual file paths
sorted-ai-bot pushed a commit to sorted-ai/opencode that referenced this pull request Apr 25, 2026
…mpliance)

**NOT Phase B completion.** Visual skeleton only. 23/39 Designer spec items PASS.
Continuation required per CTO/STATE.md — char corruption + Core Mention override.

Architecture
- Internal plugin: packages/opencode/src/cli/cmd/tui/feature-plugins/home/cockpit/
- Same-process session multiplexer (Option a, CEO approved 2026-04-23)
- Phase B scope: Roster + Stage + Overlays UI骨格 + 1 live @vega seat + 3 fixture
- Phase C scope: true 4-session parallel substrate, session router

Core changes (CTO-D-041)
- TuiThemeCurrent + 7 keys: backgroundInner/textHeadline/textDim/textGhost
  /roleBuild/roleQa/rolePlan/roleExplore (all 33 theme JSONs + generateSystem)
- home.tsx maxWidth moved inside slot (Option A', proven Session anomalyco#24)

Cockpit components (23 new files)
- roster/: ticker-bar, footer-bar, session-seat, stage-monitor, tower-control,
  session-log, hints-panel, roster
- stage/: stage, navigator, transcript (with InlinePrompt), inspector,
  status-dot (with usePulse)
- overlays/: palette (fuzzy filter), handoff, help-legend (all via Portal)
- substrate/: session-roster, ipc-bridge (Phase B minimum — session.updated tap)
- state, helpers (statusAccent/roleTint/usePulse/useBreakpoint with hysteresis),
  fixtures (4 callsign: vega/altair/orion/rigel)

Session anomalyco#25 iterations
- nested <text> → <span> × 3 (TextNodeRenderable crash fix)
- useTerminalDimensions moved from registerCockpit to component (No renderer fix)
- Portal overlays (vs sibling stack)
- Column width: width="25%" → flexBasis/minWidth=0
- Real Prompt embedded in @tower (workspaceId + ref from slot props)
- TickerBar/FooterBar: height={1} + flexShrink={0} (prevent collapse)
- Session type + callsign field (mockup @vega PM-01 · sonnet-4.6 format)
- Category B: Shift+Tab cycle, gate_state [IN_PROGRESS] display,
  coffer UNLOCKED/LOCKED on FooterBar, breakpoint hysteresis ±2 col

Known gaps (next Session scope — see P5-RST_PhaseB_Continuation_Brief_2026-04-23.md)
- Character corruption on all panels (gap / padEnd / wrapMode interaction)
- 12 MISS spec items (Palette/Handoff/Help shortcut, Roster→Stage transition,
  /login OAuth, crash fallback, fallback breakpoint verify, PC-RST mapping)
- 4 PARTIAL items (hysteresis verify, Session type gateState/frozen usage)

Build note
- OOM killer multiple hits during full build. Use:
  NODE_OPTIONS="--max-old-space-size=1024" bun script/build.ts --single --skip-embed-web-ui
bussard76 pushed a commit to bussard76/openwork that referenced this pull request May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Edit permissions window does not show full path

2 participants