fix(app): skip key handlers during IME composition in question dock#20858
Closed
yykamei wants to merge 1 commit into
Closed
fix(app): skip key handlers during IME composition in question dock#20858yykamei wants to merge 1 commit into
yykamei wants to merge 1 commit into
Conversation
The custom answer textarea in SessionQuestionDock submits on Enter without checking whether the browser is in an IME composition session. This causes CJK users' composition-confirm Enter to be treated as a form submit. Add the standard isComposing/keyCode-229 early return to both the textarea onKeyDown and the parent nav handler, matching the pattern already used in prompt-input.tsx and line-comment.tsx. Closes anomalyco#20850
Collaborator
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #20850
Type of change
What does this PR do?
The custom answer textarea in
SessionQuestionDockdoes not checkevent.isComposingbefore handling Enter, so pressing Enter to confirm a CJK IME candidate submits the answer instead of committing the composed character. This is the same class of bug fixed forLineCommentEditorin #16361.Added the
isComposing || keyCode === 229early return to both the textareaonKeyDownand the parentnavhandler.How did you verify your code works?
Tested with Japanese IME on macOS (Chrome and Safari). Enter now confirms the IME candidate without submitting the custom answer.
Screenshots / recordings
Same visual behavior as #16360 — IME composition Enter no longer triggers submit.
Checklist