fix: normalize windows path separators in session queries#20216
fix: normalize windows path separators in session queries#20216tcflying wants to merge 2 commits into
Conversation
Fixes Windows session list display issues where sessions become invisible due to path separator inconsistencies. Changes: - Add normalizePathSeparators() function to filesystem utilities - Normalize paths in session.createNext() when storing sessions - Normalize paths in Session.list() when querying by directory - Normalize paths in Session.listGlobal() when querying by directory - Normalize paths in Project.discover() when updating session project IDs This resolves GitHub Issues anomalyco#16744 and anomalyco#18029 where sessions created with backslash paths would not be visible when querying with forward slash paths, or vice versa. Related to PR anomalyco#17067 by HRronaldo Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Also normalize Windows drive letters to uppercase for consistent path matching. This ensures paths like 'c:/path' and 'C:/path' are treated the same.
|
The following comment was made by an LLM, it may be inaccurate: Potential duplicate found:
The current PR (20216) and PR #20215 have identical titles and appear to address the same issue. You should verify whether one of these is a duplicate or if they have different implementations. |
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
3 participants
Issue for this PR
Closes #16744
Closes #18029
Type of change
What does this PR do?
This PR fixes the Windows session list display issue where newly created sessions become invisible due to path separator inconsistencies. When sessions are created with backslash paths on Windows but queried with forward slash paths, the database strict string matching would fail to find them.
The root cause is that Windows paths can use either backslashes or forward slashes, and the drive letter can be lowercase (c:/) vs uppercase (C:/).
Changes made:
This ensures all path comparisons use consistent format regardless of Windows path formatting.
How did you verify your code works?
Checklist