wip: Strongly Typed Path strings and therefore fix all mismatch/normalisation issues on windows#18692
wip: Strongly Typed Path strings and therefore fix all mismatch/normalisation issues on windows#18692Hona wants to merge 44 commits into
Conversation
…rywhere # Conflicts: # packages/opencode/src/file/index.ts # packages/opencode/src/file/watcher.ts # packages/opencode/src/lsp/server.ts # packages/opencode/src/permission/index.ts # packages/opencode/src/permission/service.ts # packages/opencode/src/skill/skill.ts
Hona
changed the title
atharvau
left a comment
atharvau
left a comment
There was a problem hiding this comment.
Code Review for PR #18692: WIP Path Handling
⚠️ Work in Progress - Early Feedback
This PR appears to be a comprehensive rewrite of path handling for Windows compatibility. Since it's marked as WIP with no description and a very large diff (20k+ lines), here's some early feedback:
📋 Recommendations for Development
-
Add PR Description: Please add a detailed description explaining:
- What problems this solves
- High-level approach taken
- Breaking changes introduced
- Testing strategy
-
Consider Breaking Into Smaller PRs: This could potentially be split into:
- Type definitions and interfaces
- Core path utilities
- Migration of existing usage
- Tests and validation
-
Add Tests: Ensure comprehensive test coverage for:
- Windows-specific path scenarios
- Cross-platform compatibility
- Migration paths for existing data
-
Review vs PR #18709: This seems related to the other path handling PR (#18709). Consider how they relate and if they can be consolidated.
🔍 Ready for Review When:
- PR description added with clear goals
- Tests included for path handling logic
- Potential breaking changes documented
- WIP status removed
Happy to provide detailed technical review once the PR is ready for review!
Status: AWAITING AUTHOR (WIP)
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
3 participants
No description provided.