fix(opencode): write.ts coerce JSON objects to strings#14832
fix(opencode): write.ts coerce JSON objects to strings#14832peterdenham wants to merge 6 commits into
Conversation
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
|
The following comment was made by an LLM, it may be inaccurate: Based on my search, there is one potentially related PR: #7513: fix(opencode): coerce stringified JSON arrays/objects in tool parameters This PR may be related as it also addresses JSON coercion in tool parameters, though it appears to focus on already-stringified JSON rather than raw objects. You may want to review it to ensure there's no overlap or if it provides relevant context for this fix. |
|
Can this be merged please, possible fix for an issue with tool calling when using Qwen3-coder |
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
Issue for this PR
Closes #6918 #1498
Type of change
What does this PR do?
When writing JSON-based file formats (
.excalidraw,.json, etc.), small/quantized models e.g. qwen3-coder, pass thecontentparameter as a native JSON object rather than a serialized string. Thez.string()schema rejects this with:I've observed at least one other model hit this error, and it by-passed the write tool and wrote the file itself. Frontier models will hit the error and will know to retry with a serialized string.
This fix adds a
z.preprocess()step that serializes any object passed ascontentto a pretty-printed JSON string before Zod validates it.This fix makes sense to me, but I'm open to hearing other solutions too.
How did you verify your code works?
The reproduction prompt
write a simple diagram in excalidraw, with a qwen3-coder model, now passes.Screenshots / recordings
n/a
Checklist