Skip to content

Add functionality and improvements around design text file#33

Merged
bvreede merged 24 commits into
mainfrom
improve-design-16
Apr 20, 2023
Merged

Add functionality and improvements around design text file#33
bvreede merged 24 commits into
mainfrom
improve-design-16

Conversation

@bvreede

@bvreede bvreede commented Jan 13, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator
  • Improve the layout of the design file
  • Add a function that verifies its contents
  • Add a function that creates a design
  • (optional) Have design file created with Q&A with user

Closes #14, closes #16

@ankemt

ankemt commented Jan 13, 2023 •
edited
Loading

Copy link
Copy Markdown
Owner

Codecov Report

Patch coverage: 86.56% and project coverage change: -0.98 ⚠️

Comparison is base (6ab47de) 87.20% compared to head (0d3d617) 86.23%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
- Coverage   87.20%   86.23%   -0.98%     
==========================================
  Files           6        7       +1     
  Lines         172      218      +46     
==========================================
+ Hits          150      188      +38     
- Misses         22       30       +8
Impacted Files Coverage Δ
R/treatment_ratio.R 100.00% <ø> (ø)
R/exp_design.R 81.63% <81.63%> (ø)
R/parse_designfile.R 100.00% <100.00%> (+2.85%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

bvreede
bvreede commented Apr 7, 2023
View reviewed changes

@bvreede bvreede left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments!

Comment thread R/exp_design.R Outdated
Comment thread R/exp_design.R
path="./design.txt"){
nwells <- 48 # TODO make this a question also

write_meta(date, expID, nwells, path)

@bvreede bvreede Apr 7, 2023

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The path is not verified, so it fails without further explanation to the user.
The path should perhaps also be inquired in a prompt.

@bvreede bvreede Apr 7, 2023

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

path is now created if it does not exist. Furthermore, the path is the first argument now, which means that the function can be run as exp_design("testpath/designfile.txt").

Comment thread R/exp_design.R Outdated
Comment thread R/exp_design.R Outdated
Comment thread R/parse_designfile.R
Comment thread R/parse_designfile.R
@bvreede bvreede merged commit 59bb2ba into main Apr 20, 2023
@bvreede bvreede mentioned this pull request Apr 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

function to verify treatment design file function that creates a design template

2 participants

@bvreede @ankemt