This repository was archived by the owner on Jan 6, 2025. It is now read-only.
fix(fxLayoutGap): skip hidden element nodes#145
Merged
Conversation
Contributor
Author
|
@d3viant0ne - please review. |
fxLayoutGap should consider (and skip) hidden elements when applying layout-gap logic. fixes #136.
ThomasBurleson
force-pushed
the
wip/thomasb/fix-layout-gap-136
branch
from
509d7b7 to
3c098fc
Compare
ThomasBurleson
added
pr: needs review
pr: needs presubmit
and removed
pr: needs review
labels
kara
added
pr: merge ready
karlhaas
pushed a commit
to karlhaas/flex-layout
that referenced
this pull request
May 3, 2017
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fxLayoutGap should consider (and skip) hidden elements when applying layout-gap logic.
fixes #136.