Conversation
googlebot
added
the
cla: yes
kara
force-pushed
the
list
branch
5 times, most recently
from
c18e5a3 to
07ba824
Compare
kara
added
pr: needs review
and removed
in progress
src/components/list/list.html
Outdated
| @@ -0,0 +1 @@ | |||
| <ng-content></ng-content> No newline at end of file | |||
There was a problem hiding this comment.
optional: could inline this into the template property for list.
There was a problem hiding this comment.
Yeah, agree. Originally I separated it in case it got any larger, but it didn't. Inlining.
| $md-dense-two-line-height: 60px; | ||
| $md-dense-three-line-height: 76px; | ||
|
|
||
| @mixin md-list-item-base($font-size, $base-height, $avatar-height, |
There was a problem hiding this comment.
It might be good for these mixins to describe what's captured in the base and what is left to the specific uses.
kara
force-pushed
the
list
branch
4 times, most recently
from
871437c to
1e9bf43
Compare
| export SAUCE_USERNAME=angular-ci | ||
| export SAUCE_ACCESS_KEY=9b988f434ff8-fbca-8aa4-4ae3-35442987 | ||
| export TRAVIS_JOB_NUMBER=12345 | ||
| export BROWSER_PROVIDER_READY_FILE=/tmp/angular-material2-build/readyfile |
There was a problem hiding this comment.
Note: Added at Rob's request to help travis pass.
kara
force-pushed
the
list
branch
2 times, most recently
from
dd69303 to
d62d34d
Compare
src/components/list/list.scss
Outdated
| $md-list-top-padding: 8px; | ||
| $md-list-font-size: 16px; | ||
| $md-list-secondary-font: 14px; | ||
| //height for single-line lists |
|
Going to add a README in a follow-up PR? |
|
LGTM |
|
Yes, README coming in my next PR |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
3 participants
r: @jelbourn
Ref: #107
This PR is for the static
md-listonly, not selection or action lists.