This repository was archived by the owner on Feb 26, 2024. It is now read-only.
Adding basic history push state to the pager#37
Closed
ericduran wants to merge 3 commits intoangular:masterfrom
Closed
Adding basic history push state to the pager#37ericduran wants to merge 3 commits intoangular:masterfrom
ericduran wants to merge 3 commits intoangular:masterfrom
Conversation
Author
|
@IgorMinar Thanks for the info. I update the code to use $location. I also updated the lightbox project section to use $location since it was using history directly. So now the pager and the projects should both be working correctly. |
Author
|
I also just figured out how to listen for url changes. So this latest push makes sure the back button works with the pager. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic fix for #17.