Update auth.md change user$ = user(auth); to user$ = user(this.auth);#3640
Open
arolleaguekeng wants to merge 2 commits intoangular:mainfrom
Open
Update auth.md change user$ = user(auth); to user$ = user(this.auth);#3640arolleaguekeng wants to merge 2 commits intoangular:mainfrom
arolleaguekeng wants to merge 2 commits intoangular:mainfrom
Conversation
This PR fixes an issue in the AngularFire documentation where the auth instance is incorrectly referenced in user(auth). The correct approach is to use the injected auth instance (this.auth) instead. The updated code ensures proper dependency injection and aligns with best practices in Angular.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
yarn install,yarn testrun successfully? yesDescription
This PR fixes an issue in the AngularFire documentation where the auth instance was incorrectly referenced as user(auth), instead of using the injected instance (this.auth).
Description
Code sample