This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Not a 'real' PR, but a demo for #13108#13111
Closed
thorn0 wants to merge 1 commit intoangular:masterfrom
Closed
Conversation
Contributor
Author
|
@gkalpak Basically, namesake, you don't even need to checkout anything locally. Travis has run the tests for us. |
thorn0
added a commit
to thorn0/angular.js
that referenced
this pull request
Feb 7, 2018
This `$apply` call was needed only for tests, so it's been moved to `$httpBackend.flush`. BREAKING CHANGE: `$httpProvider.useApplyAsync` has been removed. Closes angular#13108 Closes angular#13111
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@gkalpak please check out this branch and run
grunt test:unit. You'll see that removing the$apply/$applyAsynccall has the same effect as using$applyAsync.