This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Added invokeApply parameter to $http to skip apply#12556
Closed
Utsav2 wants to merge 2 commits intoangular:masterfrom
Utsav2:http-invoke-apply
Closed
Added invokeApply parameter to $http to skip apply#12556Utsav2 wants to merge 2 commits intoangular:masterfrom Utsav2:http-invoke-apply
Utsav2 wants to merge 2 commits intoangular:masterfrom
Utsav2:http-invoke-apply
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Contributor
Author
|
I signed it! |
|
CLAs look good, thanks! |
Contributor
There was a problem hiding this comment.
so if skipApply is true, then resolveHttpPromise will not get called?
Contributor
Author
There was a problem hiding this comment.
Yeah, that's a mistake.
Contributor
Author
|
Could you have a look at this #12557? I've fixed the problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a bunch of times when we don't want a $rootScope.$apply after an http request succeeds. This stackoverflow question gives a good use case: polling.
We can also use this to do scope specific digests, which really helps performance and snappiness on mobile devices.
It also gives us a little more control over the API, and also makes it similar to $timeout.