Revert user-agent check in performance-impl - #26730
Closed
micajuine-ho wants to merge 2 commits into
Closed
Conversation
Contributor
Author
|
cc @powerivq for bundle size check |
Contributor
|
Looking at the code, I don't feel it should increase the bundle size. Ideas? |
micajuine-ho
force-pushed
the
remove_user_agent
branch
from
February 11, 2020 17:25
d791f43 to
724643b
Compare
Contributor
Author
I agree, but not sure why this would happen. @danielrozenberg Do you have any ideas? |
Contributor
|
@micajuine-ho Can you post a gist of the output for before and after? I can take a look. |
Contributor
Author
|
@kristoferbaxter Here is the gist |
Contributor
|
The change here is as follows:
I'm not certain why this is reported as an increase. |
Contributor
|
@danielrozenberg to help debugging this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check window.PerformancePaintTiming instead of user-agent to see if
first-contentful-paintandfirst-paintare supported.Reverts the installation of platform service in some places.