🏗🐛 Don't cancel watch if an edit causes a compilation error (redux) - #23023
Merged
Conversation
Contributor
Author
|
Verified this locally with |
erwinmombay
reviewed
Jun 26, 2019
erwinmombay
approved these changes
Jun 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR cleans up the old logic used to determine when to stop compilation and when to continue it during
watchby adding a new field tooptionscalledcontinueOnError. This was necessary because extensions use an additionalwatchmechanism since they need to respond to changes to.jsand.cssfiles.Addresses #13312 (comment)
Follow up to #13312
Follow up to #22659