For the amphtml-validator NPM package, require the Node.js binary to be node. - #13536
Merged
Merged
Conversation
…be node. This is more standard than the nodejs binary name, which is common on older Debian-based installations. The benefit of this change is that the postinstall script is no longer necessary.
Gregable
approved these changes
Feb 20, 2018
clawr
pushed a commit
to clawr/amphtml
that referenced
this pull request
Feb 20, 2018
…be node. (ampproject#13536) * For the amphtml-validator NPM package, require the Node.js binary to be node. This is more standard than the nodejs binary name, which is common on older Debian-based installations. The benefit of this change is that the postinstall script is no longer necessary. * fix typo * fix build.py some more
protonate
pushed a commit
to protonate/amphtml
that referenced
this pull request
Feb 26, 2018
…be node. (ampproject#13536) * For the amphtml-validator NPM package, require the Node.js binary to be node. This is more standard than the nodejs binary name, which is common on older Debian-based installations. The benefit of this change is that the postinstall script is no longer necessary. * fix typo * fix build.py some more
powdercloud
pushed a commit
to powdercloud/amphtml
that referenced
this pull request
Feb 27, 2018
powdercloud
added a commit
that referenced
this pull request
Feb 28, 2018
RanAbram
pushed a commit
to RanAbram/amphtml
that referenced
this pull request
Mar 12, 2018
…be node. (ampproject#13536) * For the amphtml-validator NPM package, require the Node.js binary to be node. This is more standard than the nodejs binary name, which is common on older Debian-based installations. The benefit of this change is that the postinstall script is no longer necessary. * fix typo * fix build.py some more
RanAbram
pushed a commit
to RanAbram/amphtml
that referenced
this pull request
Mar 12, 2018
* version bump and experimental * Remove '(CDATA)' from the error messages. Just say 'text'. * Revision bump for ampproject#13364, ampproject#13500, ampproject#13536, ampproject#13386, and ampproject#13625
protonate
pushed a commit
to protonate/amphtml
that referenced
this pull request
Mar 15, 2018
…be node. (ampproject#13536) * For the amphtml-validator NPM package, require the Node.js binary to be node. This is more standard than the nodejs binary name, which is common on older Debian-based installations. The benefit of this change is that the postinstall script is no longer necessary. * fix typo * fix build.py some more
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is more standard than the nodejs binary name, which is common
on older Debian-based installations. The benefit of this change is
that the postinstall script is no longer necessary.