Run presubmit and lint checks during every Travis PR build - #13362
Merged
Conversation
Contributor
Author
|
/to @erwinmombay Fixes will be in the second commit to make sure PR check fails for the first commit. |
Contributor
Author
|
Travis CI now fails (as it should) when there are presubmit errors in a smaller PR: https://travis-ci.org/ampproject/amphtml/jobs/338796268 |
rsimha
changed the title
erwinmombay
approved these changes
Feb 8, 2018
rsimha
changed the title
protonate
pushed a commit
to protonate/amphtml
that referenced
this pull request
Feb 26, 2018
RanAbram
pushed a commit
to RanAbram/amphtml
that referenced
this pull request
Mar 12, 2018
protonate
pushed a commit
to protonate/amphtml
that referenced
this pull request
Mar 15, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A presubmit error snuck in with #13359 because we don't run presubmit checks for certain kinds of small PRs. We should run
gulp presubmit(andgulp lint) no matter what a PR contains.This PR adds the checks and fixes the errors that were introduced.