Clean up amp-gwd-animation experiment - #12896
Merged
alanorozco merged 6 commits intoJan 28, 2018
Merged
Conversation
…* -> validator-amp4ads-*).
…-animation-experiment
…nimation-experiment
aghassemi
approved these changes
Jan 24, 2018
Contributor
|
@aghassemi @alanorozco This PR appears to have made the Could you comment on whether that seems likely? |
jonkeller
pushed a commit
to jonkeller/amphtml
that referenced
this pull request
Jan 29, 2018
* Initial validator tests for amp-gwd-animation. * Clean up amp-gwd-animation experiment (ampproject#11238). * amp-gwd-animation validator filename test corrections (validator-amp-* -> validator-amp4ads-*). * Fix amp-gwd-animation validator file names.
RanAbram
pushed a commit
to RanAbram/amphtml
that referenced
this pull request
Mar 12, 2018
* Initial validator tests for amp-gwd-animation. * Clean up amp-gwd-animation experiment (ampproject#11238). * amp-gwd-animation validator filename test corrections (validator-amp-* -> validator-amp4ads-*). * Fix amp-gwd-animation validator file names.
protonate
pushed a commit
to protonate/amphtml
that referenced
this pull request
Mar 15, 2018
* Initial validator tests for amp-gwd-animation. * Clean up amp-gwd-animation experiment (ampproject#11238). * amp-gwd-animation validator filename test corrections (validator-amp-* -> validator-amp4ads-*). * Fix amp-gwd-animation validator file names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
amp-gwd-animationexperiment entry and code guards (resolves #11238).Add validator test files.