merge queue: embarking main (c18c02c) and #1062 together#1081
Closed
mergify[bot] wants to merge 3 commits intomainfrom
Closed
merge queue: embarking main (c18c02c) and #1062 together#1081mergify[bot] wants to merge 3 commits intomainfrom
mergify[bot] wants to merge 3 commits intomainfrom
Conversation
The "request failed" message hid the root cause (TLS, DNS, timeout) because the code avoided wrapping *url.Error to prevent leaking tokens. Unwrap *url.Error to extract only the inner network error, which is safe to expose. Users connecting to internal instances (eg GitLab behind a corporate CA) now see actionable diagnostics like "request failed: tls: failed to verify certificate" instead of the opaque "request failed". Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Previously, if one API version probe (e.g. v3) received a normal HTTP response (like 404) but the other (v2) hit a network error, the function returned "request failed" even though the server was reachable. Track whether any probe received an HTTP response and only surface the network error when none did. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 This pull request has been checked successfully and will be merged soon. 🎉
Branch main (c18c02c) and #1062 are embarked together for merge.
This pull request has been created by Mergify to speculatively check the mergeability of #1062.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue rule
defaultfor merge:#approved-reviews-by >= 1[🛡 GitHub repository ruleset ruleprotect-main]#changes-requested-reviews-by = 0[🛡 GitHub repository ruleset ruleprotect-main]Required conditions to stay in the queue:
#approved-reviews-by >= 1[🛡 GitHub repository ruleset ruleprotect-main]#approved-reviews-by>=1#changes-requested-reviews-by = 0[🛡 GitHub repository ruleset ruleprotect-main]#changes-requested-reviews-by=0check-success=End-to-End Testscheck-success=test-local-dev-simulationcheck-success=validate-manifests