Skip to content

merge queue: embarking main (c18c02c) and #1062 together#1081

Closed
mergify[bot] wants to merge 3 commits intomainfrom
mergify/merge-queue/3dbd483496
Closed

merge queue: embarking main (c18c02c) and #1062 together#1081
mergify[bot] wants to merge 3 commits intomainfrom
mergify/merge-queue/3dbd483496

Conversation

@mergify
Copy link
Copy Markdown

@mergify mergify bot commented Mar 27, 2026

🎉 This pull request has been checked successfully and will be merged soon. 🎉

Branch main (c18c02c) and #1062 are embarked together for merge.

This pull request has been created by Mergify to speculatively check the mergeability of #1062.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.

Required conditions of queue rule default for merge:

Required conditions to stay in the queue:

---
checking_base_sha: c18c02ce8216af9170edd704876dec76104c22ec
previous_failed_batches: []
pull_requests:
  - number: 1062
    scopes: []
scopes: []
...

ktdreyer and others added 3 commits March 27, 2026 13:03
The "request failed" message hid the root cause (TLS, DNS,
timeout) because the code avoided wrapping *url.Error to
prevent leaking tokens. Unwrap *url.Error to extract only
the inner network error, which is safe to expose.

Users connecting to internal instances (eg GitLab behind a
corporate CA) now see actionable diagnostics like
"request failed: tls: failed to verify certificate" instead
of the opaque "request failed".

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Previously, if one API version probe (e.g. v3) received a normal HTTP
response (like 404) but the other (v2) hit a network error, the
function returned "request failed" even though the server was
reachable. Track whether any probe received an HTTP response and only
surface the network error when none did.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@mergify mergify bot closed this Mar 27, 2026
@mergify mergify bot deleted the mergify/merge-queue/3dbd483496 branch March 27, 2026 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant