fix: Correct pre-commit template path in PrecommitHooksFixer

[rh-rahulshetty]

Description

The PrecommitHooksFixer was using an incorrect template path (precommit-{lang}.yaml.j2) that doesn't match the actual template structure, causing TemplateNotFound errors when running the align command from different directory contexts.

When running agentready align . on a repository without pre-commit hooks, the following template error was observed:

  File "/home/rashetty/Desktop/agentready/agentready/.venv/lib64/python3.13/site-packages/jinja2/loaders.py", line 380, in get_source
    raise TemplateNotFound(template)
jinja2.exceptions.TemplateNotFound: precommit-python.yaml.j2

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update
• Refactoring (no functional changes)
• Performance improvement
• Test coverage improvement

Related Issues

Fixes #
Relates to #

Changes Made

• src/agentready/fixers/testing.py: Fixed template path from precommit-{lang}.yaml.j2 to {lang}/precommit.yaml.j2 to match actual template structure

Testing

• Unit tests pass (pytest)
• Integration tests pass
• Manual testing performed
• No new warnings or errors

Checklist

• My code follows the project's code style
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published

Screenshots (if applicable)

Additional Notes

[github-actions]

AgentReady Code Review - PR #269

Overview

PR: fix: Correct pre-commit template path in PrecommitHooksFixer
Type: Bug Fix
Complexity: Low (Single file, 3 line changes)
AgentReady Score Impact: Affects precommit_hooks attribute (Tier 2, 3% weight)

---

Executive Summary

✅ APPROVED - This is a well-targeted bug fix that corrects a template path mismatch causing TemplateNotFound errors when running agentready align.

Key Findings:

• ✅ Correctly fixes template path from precommit-{lang}.yaml.j2 to {lang}/precommit.yaml.j2
• ✅ Matches actual directory structure in src/agentready/templates/bootstrap/
• ⚠️ Missing unit tests for PrecommitHooksFixer
• ⚠️ Broad exception handling could mask other issues
• ℹ️ Impacts AgentReady's ability to auto-fix repositories missing pre-commit hooks

---

AgentReady Attribute Analysis

Affected Attributes

Attribute	Status	Impact
precommit_hooks	✅ IMPROVED	This fix enables the fixer to work correctly
test_coverage	⚠️ NEEDS IMPROVEMENT	No tests for PrecommitHooksFixer (line 128 in test_fixer_service.py only counts it)
type_annotations	✅ PASS	All type hints present
inline_documentation	✅ PASS	Good docstrings and comments added

Score Impact Calculation

Current State: When agentready align is run on a repo without pre-commit hooks:

• ❌ Before this fix: TemplateNotFound error → No fix applied → 0 points gained
• ✅ After this fix: Template loads correctly → Fix applied → ~3.0 points gained (Tier 2, 3% weight)

Projected Repository Score Improvement: +3.0 points (for repos missing pre-commit hooks)

---

Code Quality Assessment

✅ Strengths

1. Root Cause Identified: The fix correctly identifies the mismatch between expected path format and actual directory structure
2. Consistent Fallback: Both the try block and except block now use the same path format
3. Verified Template Existence: All supported languages have templates at the correct paths (python, javascript, go, _base)
4. Type Safety: All type annotations present (testing.py:46-55)
5. Documentation: Added helpful comment explaining fallback behavior (line 52)

⚠️ Issues & Recommendations

1. CRITICAL: Missing Unit Tests (Tier 1 Impact)

Issue: No tests exist for PrecommitHooksFixer, only a count assertion in test_fixer_service.py:128-129

Priority: HIGH - Test coverage is a Tier 1 attribute (10% weight)

Recommended tests:

• Test template path resolution for Python, JavaScript, Go
• Test fallback behavior for unsupported languages
• Test fix application (dry-run and real)
• Verify language-specific hook content

2. MEDIUM: Overly Broad Exception Handling (Security & Debugging Concern)

Issue: except Exception: catches all exceptions, masking potential issues (testing.py:51)

Recommendation: Replace with specific TemplateNotFound exception from Jinja2

Benefits:

• Prevents masking of unexpected errors (e.g., filesystem permission issues)
• Improves debuggability
• Adds logging for observability
• Aligns with AgentReady's structured_logging attribute

Priority: MEDIUM

3. LOW: Missing Edge Case - What if Python template also missing?

Recommendation: Add defensive fallback to _base template

Priority: LOW (Python template exists in the codebase, but defensive programming is good practice)

---

Security Analysis

✅ No Security Vulnerabilities Detected

Category	Status	Notes
Command Injection	✅ SAFE	No user input in shell commands
Path Traversal	✅ SAFE	Template paths are constructed from language detection, not user input
Template Injection	✅ SAFE	Jinja2 templates are static and bundled with the package

---

Best Practices Compliance

✅ Follows AgentReady Guidelines

• ✅ Conventional Commits: Commit message follows fix: <description> format
• ✅ Type Annotations: All functions have proper type hints
• ✅ Inline Documentation: Docstrings present and descriptive
• ✅ Separation of Concerns: Fix is localized to the fixer class
• ✅ Minimal Change Scope: Only modifies what's necessary

⚠️ Needs Improvement

• ⚠️ Test Coverage: No unit tests for PrecommitHooksFixer (see Issue [P0] Create Automated Demo #1)
• ⚠️ Error Handling: Overly broad exception catching (see Issue [P0] Fix Critical Security & Logic Bugs from Code Review #2)

---

Recommendations Summary

Required Before Merge

1. Add unit tests for PrecommitHooksFixer (HIGH priority)

Recommended Improvements

2. Replace broad exception with specific TemplateNotFound catch (MEDIUM priority)
3. Add defensive fallback to _base template (LOW priority)
4. Add structured logging for template fallback events (LOW priority)

---

Conclusion

VERDICT: ✅ APPROVE WITH RECOMMENDATIONS

This is a solid bug fix that correctly addresses the template path mismatch. The code change is minimal, targeted, and safe. However, the lack of unit tests for PrecommitHooksFixer is a gap that should be addressed.

Recommended Merge Path:

1. Option A (Ideal): Add unit tests, then merge
2. Option B (Acceptable): Merge now, create follow-up issue for tests
3. Option C (Not Recommended): Merge without tests

AgentReady Certification Impact:

• Enables automated fixing of precommit_hooks attribute for target repositories
• Supports AgentReady's mission to improve repository AI-readiness
• Aligns with Tier 2 Critical attributes (pre-commit hooks prevent bad commits)

---

Review conducted by: AgentReady Code Review Analysis
Date: 2026-01-29
Reviewers: @claude (sonnet-4-5)

[jeremyeder]

this is good to go - would you mind looking at why the CI tests are failing? i dont think its related to this PR but if you could take a look I would appreciate it.

[rh-rahulshetty]

It seems the earlier CI failure was due to formatting issue in couple of files. Have run the black . command to format them.

Also I might need to get some permission to run the check automatically: https://github.com/ambient-code/agentready/pull/269/checks

[github-actions]

📈 Test Coverage Report

Branch	Coverage
This PR	65.2%
Main	65.2%
Diff	✅ +0%

---

Coverage calculated from unit tests only

[github-actions]

🎉 This PR is included in version 2.24.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀