Xiaoya refactor publisher#48
Open
xiaoyachong wants to merge 3 commits into
Open
Conversation
dylanmcreynolds
requested changes
May 4, 2026
Contributor
dylanmcreynolds
left a comment
There was a problem hiding this comment.
I think we can make this simpler. See commend.
dylanmcreynolds
approved these changes
May 6, 2026
Contributor
dylanmcreynolds
left a comment
There was a problem hiding this comment.
I approved. Is this mergable?
taxe10
approved these changes
May 7, 2026
taxe10
left a comment
There was a problem hiding this comment.
All looks good. I left some very minor comments.
| parts.extend(root_segments) | ||
| parts.append(date_path) | ||
| parts.append(uuid) | ||
| parts.append(ARRAY_KEY) |
There was a problem hiding this comment.
I think ARRAY_KEY is referenced before it's defined
| self.poll_interval_sec = poll_interval_sec | ||
| self.frame_poll_interval_sec = frame_poll_interval_sec | ||
| self.unchanged_cycles_threshold = unchanged_cycles_threshold | ||
| self.seen_scans_file = seen_scans_file |
There was a problem hiding this comment.
Suggested change
| self.seen_scans_file = seen_scans_file | |
| self.seen_scans_file = Path(seen_scans_file) |
| poll_interval_sec=poll_interval_sec, | ||
| frame_poll_interval_sec=frame_poll_interval_sec, | ||
| unchanged_cycles_threshold=unchanged_cycles_threshold, | ||
| seen_scans_file=seen_scans_file, |
There was a problem hiding this comment.
Suggested change
| seen_scans_file=seen_scans_file, | |
| self.seen_scans_file = Path(seen_scans_file) |
| return | ||
| if isinstance(message, RawFrameEvent): | ||
| message = message.model_dump() | ||
| # message["image"] = SerializableNumpyArrayModel.serialize_array( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main purpose of this PR is to move the
Tiledpublisher fromLSEtoarroyoXPS, and to havearroyoXPSsend results toLSEviaZMQinstead of using aWebSocketconnection.Tiledand aZMQmessage is sent toLSEusing the same publisher, XPSTiledResultPublisher.XPSTiledResultPublisher, we import:from arroyosas.schemas import RawFrameEvent, SASStart, SASStop, SerializableNumpyArrayModelSince both
arroyosasandarroyoxpssend the same message types (RawFrameEvent,SASStart,SASStop) toLSE, it may make sense to move these schemas intoarroyopyand rename them (e.g., remove theSASprefix).Tiledunless astartmessage has been received. For example, ifsplash_timepixstarts beforearroyoxps, theTiledpublisher logs the following message:Received scan 'None' frame 49 but no start message has been received yet — discarding frame to avoid Tiled index desync.Tiledstructure: