Skip to content

Fix issue with the inputs including || in the value#125

Merged
AdamJHall merged 3 commits intomainfrom
feature/DO-1953-Update-PWA-Deploy
Apr 10, 2026
Merged

Fix issue with the inputs including || in the value#125
AdamJHall merged 3 commits intomainfrom
feature/DO-1953-Update-PWA-Deploy

Conversation

@AdamJHall
Copy link
Copy Markdown
Contributor

Description of the proposed changes
Input values are including the || in them as it is not evaluated at runtime. I've moved it into the templating functions so it actually gets evaluated and not printed.

Example:

Invalid bucket name "pwa-staging.ovarohome.com.au || ": Bucket name must match the regex "^[a-zA-Z0-9.\-_]{1,255}$" or be an ARN matching the regex "^arn:(aws).*:(s3|s3-object-lambda):[a-z\-0-9]*:[0-9]{12}:accesspoint[/:][a-zA-Z0-9\-.]{1,63}$|^arn:(aws).*:s3-outposts:[a-z\-0-9]+:[0-9]{12}:outpost[/:][a-zA-Z0-9\-]{1,63}[/:]accesspoint[/:][a-zA-Z0-9\-]{1,63}$"

REF: https://github.com/aligent/otr-pwa/actions/runs/24171707023/job/70544578503

Notes to reviewers

ℹ️ When you've finished leaving feedback, please add a final comment to the PR tagging the author, letting them know that you have finished leaving feedback

Copy link
Copy Markdown

@tmthrgd-aligent tmthrgd-aligent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are one more cases you missed: CLOUDFRONT_DISTRIBUTION_ID on line 488.

Copy link
Copy Markdown

@tmthrgd-aligent tmthrgd-aligent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the docs, this syntax looks correct now. LGTM.

@AdamJHall AdamJHall merged commit 9d5f93f into main Apr 10, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants