Skip to content

Add OkHttp#992

Closed
ManuInDenWolken wants to merge 1 commit into
akullpp:masterfrom
ManuInDenWolken:okhttp
Closed

Add OkHttp#992
ManuInDenWolken wants to merge 1 commit into
akullpp:masterfrom
ManuInDenWolken:okhttp

Conversation

@ManuInDenWolken

Copy link
Copy Markdown
Contributor

OkHttp is a common-used HTTP client.

@shathor

shathor commented Jul 25, 2022

Copy link
Copy Markdown
Contributor

OkHttp was removed in PR: #858 as it is not written in Java (anymore)

@ManuInDenWolken

Copy link
Copy Markdown
Contributor Author

My bad. Nevertheless, it's still a commonly used library. Since it's used on the entire Java platform, it should be added in my opinion. This list represents a useful piece of resources for the Java programming language, thus also a candidate for this set.

@ManuInDenWolken ManuInDenWolken mentioned this pull request Jul 26, 2022
@ManuInDenWolken

ManuInDenWolken commented Jul 26, 2022

Copy link
Copy Markdown
Contributor Author

My bad. Nevertheless, it's still a commonly used library. Since it's used on the entire Java platform, it should be added in my opinion. This list represents a useful piece of resources for the Java programming language, thus also a candidate for this set.

As the description says, this repository is a "list of awesome frameworks, libraries and software for the Java programming language." Since "for" means exactly "for" and not "written in", that also includes dependencies commonly used in Java (too). OkHttp (and Javalin) are such dependencies.
Your entire PR 858 got built upon this misunderstanding - also the fault of akullpp, I mean. For the cases, a base software is written in another language than Java while there's only a client for the Java platform, I chime in with your reason. But the libraries written in Kotlin, Groovy or Scala... if it's commonly used in Java, there should be a listing for it. Even if it's written in Kotlin. But once such items are removed from the list for the reasons stated, this list loses any practical use given to it by the philosophy it's built upon.

@shathor

shathor commented Jul 26, 2022

Copy link
Copy Markdown
Contributor

I don't want to repeat the discussion from PR 858.

@ManuInDenWolken

Copy link
Copy Markdown
Contributor Author

And I won't. I understand your reasoning, but also see the practical aspects. I argue without consideration of other "awesome" libraries, and weigh what's the best practical option for people consulting this list. This PR remains open, and with a detailed reason it'll be merged.

@akullpp akullpp closed this Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants