Merged
Conversation
akhundMurad
approved these changes
Apr 12, 2024
Owner
akhundMurad
left a comment
akhundMurad
left a comment
There was a problem hiding this comment.
Thank you again! @attevaltojarvi
Owner
|
@attevaltojarvi please resolve the issues |
Contributor
Author
|
Apparently the CI runs in python 3.10 whereas I'm running python 3.11, and |
Contributor
Author
|
@akhundMurad seems that the spec has just been updated: jetify-com/typeid@26a84e8 How would you like to handle this? It now causes the spec tests to fail, unrelated to these other changes. |
Owner
|
@attevaltojarvi Yep, I am aware. Planning to create a new MR. |
Owner
|
Hello @attevaltojarvi. Could you please pull the main branch? I want to run tests and then include your PR in the release. |
Contributor
Author
|
Done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #9, here are the proposed improvements (plus some tests cleanup to get rid of warnings raised by pytest).