Move folders: log phantom-move collisions as INFO + DEBUG, not WARNING#696
Merged
ajslater merged 1 commit intov1.11-performancefrom May 2, 2026
Merged
Conversation
The poller emits ``dirs_moved`` for inode-matched delete/add pairs. When the destination path of a "move" is already a known ``Folder`` row, ``_remove_move_collisions`` correctly drops the move (it would explode the unique constraint and isn't needed — the destination is already correctly tracked) and lets the source-side absence fall out via the next delete pass. This is normal reconciliation, not a fault. The previous WARNING made it look like something had gone wrong: ``` 2026-05-02 03:54:40 | WARNING | Not moving folders to destinations that would collide with existing database folders: ['…', '…', '…'] ``` …and prompted operators to investigate something that needed no investigating. Replace with: * one-line INFO: ``Resolved 3 phantom folder moves by skipping the rename and leaving the destinations in place.`` * DEBUG with the actual path list, for anyone who does want to see which folders were involved. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The poller emits
dirs_movedfor inode-matched delete/add pairs. When the destination path of a "move" is already a knownFolderrow,_remove_move_collisionscorrectly drops the move (it would explode the(library, path)unique constraint, and isn't needed — the destination is already correctly tracked) and lets the source-side absence fall out via the next delete pass.This is normal reconciliation, not a fault. The previous WARNING made it look like something had gone wrong:
…and prompted operators to investigate something that needed no investigating.
Change
Resolved 3 phantom folder moves by skipping the rename and leaving the destinations in place.Same data, healthier signal-to-noise.
Test plan
make test-python T=tests/importer/— green.ruff check,basedpyright— clean.🤖 Generated with Claude Code