Skip to content

Fix spurious doc test failures#106

Merged
letmutx merged 1 commit into
aisk:masterfrom
letmutx:fix-spurious-failures
Feb 4, 2020
Merged

Fix spurious doc test failures#106
letmutx merged 1 commit into
aisk:masterfrom
letmutx:fix-spurious-failures

Conversation

@letmutx

@letmutx letmutx commented Feb 3, 2020

Copy link
Copy Markdown
Collaborator

Fix #105

@codecov-io

codecov-io commented Feb 3, 2020

Copy link
Copy Markdown

Codecov Report

Merging #106 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #106   +/-   ##
=======================================
  Coverage   50.58%   50.58%           
=======================================
  Files          10       10           
  Lines         682      682           
=======================================
  Hits          345      345           
  Misses        337      337
Impacted Files Coverage Δ
src/client.rs 95.89% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update baa9aa8...fee659e. Read the comment docs.

@letmutx

letmutx commented Feb 3, 2020

Copy link
Copy Markdown
Collaborator Author

@aisk CommitCheck doesn't show the expected commit message format. Is it documented somewhere? Please add it to README.md.

@aisk

aisk commented Feb 4, 2020

Copy link
Copy Markdown
Owner

Sorry I'll add it to README latter. For now, all commit' title must be starting with https://gitmoji.carloscuesta.me/ , and a white space and lower case titles, like:

:bug: fixed something

@letmutx letmutx force-pushed the fix-spurious-failures branch from eb70b1d to fee659e Compare February 4, 2020 16:25
@letmutx letmutx merged commit dced588 into aisk:master Feb 4, 2020
@letmutx letmutx deleted the fix-spurious-failures branch February 4, 2020 16:31
@aisk aisk mentioned this pull request Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Spurious doc test failures

3 participants