Make UnmountVolume a hard crash failure during suspend/pause. - #666
Open
Michelle Au (msau42) wants to merge 1 commit into
Open
Make UnmountVolume a hard crash failure during suspend/pause.#666Michelle Au (msau42) wants to merge 1 commit into
Michelle Au (msau42) wants to merge 1 commit into
Conversation
Michelle Au (msau42)
force-pushed
the
unmount-detach-coordination
branch
from
July 31, 2026 20:34
8772310 to
2347e76
Compare
Zoe Zhao (zoez7)
previously approved these changes
Jul 31, 2026
| // TODO cleanup orphaned volumes | ||
| _ = s.unmountExternalVolumes(ctx, actorUID, req.GetSpec().GetVolumes()) | ||
| } | ||
| }() |
Collaborator
There was a problem hiding this comment.
Wait... this was in AteomHerder.Run, so we were removing external volumes right after telling ateom to run the workload?
Collaborator
Author
There was a problem hiding this comment.
Previous behavior tried to rollback operations on failure to try to cleanup node state.
So if Run() encountered some failure, then we would try to undo the mounts to cleanup.
But now I'm deciding that it's better to just leave the node in a partial state, and have an explicit cleanup flow to handle the cleanup.
Don't try to rollback mounts during Resume/Run. Instead should introduce a way to cleanup actor resources when an actor is in a failed state. Discussion in agent-substrate#643.
Michelle Au (msau42)
force-pushed
the
unmount-detach-coordination
branch
from
July 31, 2026 23:57
2347e76 to
69bb342
Compare
Michelle Au (msau42)
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't try to rollback mounts during Resume/Run. Instead should introduce a way to cleanup actor resources when an actor is in a failed state. Discussion in #643.