feat: Add control plane telemetry - actor crashes counter and operation labels - #642
Open
Angela (Angelawork) wants to merge 6 commits into
Open
Conversation
Angela (Angelawork)
force-pushed
the
feature/actor-crashes-telemetry
branch
2 times, most recently
from
July 30, 2026 20:24
4099ed0 to
0e45f4f
Compare
Angela (Angelawork)
force-pushed
the
feature/actor-crashes-telemetry
branch
from
July 30, 2026 20:45
0e45f4f to
65c4522
Compare
Angela (Angelawork)
force-pushed
the
feature/actor-crashes-telemetry
branch
from
July 31, 2026 16:56
fa2c10c to
f69db52
Compare
Angela (Angelawork)
force-pushed
the
feature/actor-crashes-telemetry
branch
from
July 31, 2026 17:36
f69db52 to
5c4183e
Compare
Angela (Angelawork)
force-pushed
the
feature/actor-crashes-telemetry
branch
from
July 31, 2026 17:52
2bb53ba to
b19d783
Compare
Jeff Luo (JeffLuoo)
requested changes
Jul 31, 2026
Angela (Angelawork)
force-pushed
the
feature/actor-crashes-telemetry
branch
from
July 31, 2026 18:58
b19d783 to
ab0a9bc
Compare
Angela (Angelawork)
force-pushed
the
feature/actor-crashes-telemetry
branch
from
July 31, 2026 20:59
ab0a9bc to
1d581e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #564 (Part 2)
Description
This PR implements the second part of #564 by adding telemetry counter instrumentation for
ate.actor.crashesinateapiand establishing bounded label validation for operations and crash failure causes.Key Changes:
maybeCrashActorandcrashActorto referenceateattr.OperationName*constants and normalizeopName.ReasonCorruptedAssignment,ReasonWorkerPodGone,ReasonWorkerReassigned) acrossworkflow_resume.go,workflow_suspend.go, andworkflow_pause.go.WorkerPoolSyncer.releaseActorOnDeadWorkerinsyncer.goto recordrecordActorCrashwhen background pod deletion crashes an actor.FinalizePausedStepinworkflow_pause.goto recordrecordActorCrashwhennodeNameis missing during pause finalization.ate_actor_crashestoPlatformMetricPrefixesincollector_metrics.go.metrics_test.goto preventAlreadyExistserrors on test reruns.metrics_test.goto trigger an actor crash viaUpdateActorandResumeActor, assertingate_actor_crashesemission and label presence in OTel collector scrape outputs.Testing
go test -buildvcs=false ./cmd/ateapi/internal/controlapi/...go test -buildvcs=false ./cmd/atenet/internal/router/...make testE2E Test
./hack/create-kind-cluster.sh./hack/install-ate-kind.sh --deploy-ate-system --deploy-demo-counter./hack/run-e2e.sh ./internal/e2e/suites/metrics/...