This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Update CSS at-rule hints#14013
Merged
ficristo merged 4 commits intoadobe:masterfrom Jan 14, 2018
valtlai:valtlai/css-at-rules
Merged
Update CSS at-rule hints#14013ficristo merged 4 commits intoadobe:masterfrom valtlai:valtlai/css-at-rules
ficristo merged 4 commits intoadobe:masterfrom
valtlai:valtlai/css-at-rules
Conversation
Add @counter-style and @font-feature-values. (Align colons.)
petetnt
reviewed
Jan 8, 2018
| "@charset": "Defines the character set used by the style sheet.", | ||
| "@counter-style": "Defines specific counter styles that are not part of the predefined set of styles.", | ||
| "@font-face": "Describes the aspect of an external font to be downloaded.", | ||
| "@font-feature-values": "Define common names in font-variant-alternates for feature activated differently in OpenType.", |
Collaborator
There was a problem hiding this comment.
MDN phrases this as Defines a common name in font-variant-alternates for features activated differently in OpenType., not quite sure which one is more correct though
¯\_(ツ)_/¯
Contributor
Author
There was a problem hiding this comment.
Hmm, these descriptions are from another MDN page.
Collaborator
There was a problem hiding this comment.
Then it's good enough for me (maybe fix them in MDN too? 😂 )
Contributor
Author
There was a problem hiding this comment.
Made it a bit more consistent by adding -s. 😇
petetnt
approved these changes
Jan 8, 2018
ficristo
suggested changes
Jan 13, 2018
Collaborator
ficristo
left a comment
ficristo
left a comment
There was a problem hiding this comment.
Fix the test.
Otherwise LGTM.
Contributor
Author
|
Fixed the test. |
ficristo
approved these changes
Jan 14, 2018
Collaborator
|
Thank you! |
ficristo
pushed a commit
to quadre-code/quadre
that referenced
this pull request
Jan 15, 2018
* Update CSS at-rules Add @counter-style and @font-feature-values. (Align colons.) * Revert colon aligment * Make CSS at-rule descriptions bit more consistent * Fix the unit test for CSS At-Rule Hints
ficristo
pushed a commit
to quadre-code/quadre
that referenced
this pull request
Jan 15, 2018
* Update CSS at-rules Add @counter-style and @font-feature-values. (Align colons.) * Revert colon aligment * Make CSS at-rule descriptions bit more consistent * Fix the unit test for CSS At-Rule Hints
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
@counter-styleand@font-feature-valuesat-rules.Reorder the rules alphabetically.