Add closure variables into global scope#431
Conversation
|
I think you're off to a good start, but this is failing the tests. Please try running the tests locally with e.g. |
|
I reproduced test fails and fixed it |
| globalz = dict(func.__globals__) | ||
|
|
||
| for cell in func.__closure__ or (): | ||
| cell_contents = cell.cell_contents |
There was a problem hiding this comment.
Type of cell_contents is Any. So I'm NOT SURE here
Is it better to check if cell_contents is type instance?
What else may it be?
There was a problem hiding this comment.
So, I was right in this question
I don't see this test? Or a changelog note. |
98dc6dd to
b4f038e
Compare
|
I just added two tests which fail. |
Fixes #430