feat: remove unused nodes before each step in GNN workflow#5448
Open
benjaminhuth wants to merge 14 commits into
Open
feat: remove unused nodes before each step in GNN workflow#5448benjaminhuth wants to merge 14 commits into
benjaminhuth wants to merge 14 commits into
Conversation
github-actions
Bot
added
Component - Examples
benjaminhuth
force-pushed
the
feature/gnn-remove-unused-nodes
branch
from
6150a21 to
b14d556
Compare
Contributor
…ependency The torchscript gnn.pt model uses torch_scatter::scatter_max which is not available in CI. Switch to onnx_models/gnn.onnx, consistent with the fix already applied in tmp/gnn-remove-unused-nodes-with-main. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
mimodekjaer
previously approved these changes
Jun 10, 2026
mimodekjaer
left a comment
mimodekjaer
left a comment
There was a problem hiding this comment.
Seems okay.
The only real comment is that the clang formatting should be fixed. :)
The metric learning workflow uses torch_scatter which is not available in CI. Switched test_gnn_shrink_nodes_same_output to the ODD GNN module map workflow, which uses the ONNX model already proven to work in CI. Added shrinkNodes parameter to runGnnModuleMap and pass it through to addGnn. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
acts-policybot
Bot
dismissed
mimodekjaer’s stale review
Invalidated by push of d42eefa
Switch from .onnx to .pt model (ONNX CUDA provider not available in all environments) and explicitly delete the sequencer after each run so the ROOT TFile destructor flushes before hash_root_file reads it. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
mimodekjaer
suggested changes
Jun 15, 2026
mimodekjaer
left a comment
mimodekjaer
left a comment
There was a problem hiding this comment.
I think all in all, that it is good :), but I think it would be good to check that the root files are generated, before accessing them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.