Skip to content

Fix flakey test with buffers on macOS #817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luketomlinson merged 1 commit into from
May 21, 2021
Merged

Fix flakey test with buffers on macOS #817

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/exec/__tests__/scripts/stdoutputspecial.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
//first half of © character
process.stdout.write(Buffer.from([0xC2]), (err) => {
//write in the callback so that the second byte is sent separately
process.stdout.write(Buffer.from([0xA9])) //second half of © character
setTimeout(() => {
process.stdout.write(Buffer.from([0xA9])) //second half of © character
}, 5000)

})
1 change: 0 additions & 1 deletion packages/exec/src/exec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@ export async function getExecOutput(
stdout += stdoutDecoder.end()
stderr += stderrDecoder.end()

//return undefined for stdout/stderr if they are empty
return {
exitCode,
stdout,
Expand Down