fix: only-issue-types does not affect PRs#1338
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the onlyIssueTypes filtering so it applies only to issues (not pull requests), preventing PRs from being excluded due to missing issue_type.
Changes:
- Skip
onlyIssueTypesfiltering for pull requests inIssuesProcessor. - Add a unit test ensuring PRs are not filtered out by
onlyIssueTypes. - Document in README that
onlyIssueTypesdoes not affect PRs.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/classes/issues-processor.ts | Adjusts filtering condition to bypass onlyIssueTypes for PRs. |
| tests/only-issue-types.spec.ts | Adds coverage for PR behavior when onlyIssueTypes is set. |
| README.md | Documents that the option does not apply to pull requests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
only-issue-types does not affect PRs
|
Thanks for the fix! Looks like check-dist is failing — could you update the generated dist files when you get a chance? |
|
Hi @trueberryless , just a gentle reminder on this one — check-dist is still failing because the generated dist files need to be updated. When you have a moment, could you regenerate and push those changes? Thanks! |
|
Hi! Sorry, I completely forgot to update this last week when you mentioned it first. Should be good to go know 😉 |
Description:
When the
only-issue-typesis set, this should only affect issues, not Pull Requests.However, since the GitHub API treats PRs and issues all as
issues, this type checking was missing and all PRs were ignored if theonly-issue-typeswas set.Related issue:
only-issue-types#1331Check list: